[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4F69DAEF.5010407@mellanox.com>
Date: Wed, 21 Mar 2012 15:43:11 +0200
From: Amir Vadai <amirv@...lanox.com>
To: Eric Dumazet <eric.dumazet@...il.com>
CC: "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
Roland Dreier <roland@...estorage.com>,
Oren Duer <oren@...lanox.com>,
Amir Vadai <amirv@...lanox.co.il>
Subject: Re: [PATCH V1 4/6] net/mlx4_en: Set max rate-limit for a TC
On 03/21/2012 12:12 PM, Eric Dumazet wrote:
> Le mercredi 21 mars 2012 à 11:25 +0200, Amir Vadai a écrit :
>> From: Amir Vadai<amirv@...lanox.co.il>
>>
>> Set max rate-limit using sysfs file /sys/class/net/<interface>/qos/ratelimit
>>
>> To set, enter a space separated list of values in units of 100Mbps. For
>> example to set ratelimit of 5G to TC0 and 10G for the reset on eth2 issue:
>> echo 50 100 100 100 100 100 100 100 100> /sys/class/net/eth2/qos/ratelimit
>>
>
> Oh thats not very user friendly.
>
> I suggest one value per file (Its probably a generic /sys rule anyway)
> and not using 100Mps for the unit, even if it is the base granularity of
> this hardware.
>
>
> /sys/class/net/eth2/qos/0/ratelimit
> ...
> /sys/class/net/eth2/qos/7/ratelimit
>
>
Ok, will change the structure to be:
/sys/class/net/eth2/qos/tc0/ratelimit
...
/sys/class/net/eth2/qos/tc7/ratelimit
And use units of 1Mbps
- Amir
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists