netdev - Re: [patch] netlabel: use GFP flags from caller instead of GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120322.193050.528451453813300397.davem@davemloft.net>
Date:	Thu, 22 Mar 2012 19:30:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	paul@...l-moore.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] netlabel: use GFP flags from caller instead of
 GFP_ATOMIC

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Thu, 22 Mar 2012 09:41:01 +0300

> This function takes a GFP flags as a parameter, but they are never used.
> We don't take a lock in this function so there is no reason to prefer
> GFP_ATOMIC over the caller's GFP flags.
> 
> There is only one caller, cipso_v4_map_cat_rng_ntoh(), and it passes
> GFP_ATOMIC as the GFP flags so this doesn't change how the code works.
> It's just a cleanup.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html