netdev - Re: [PATCH linux-next] dmaengine: add context parameter fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332758906.19804.97.camel@vkoul-udesk3>
Date:	Mon, 26 Mar 2012 16:18:26 +0530
From:	Vinod Koul <vinod.koul@...ux.intel.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Fabio Estevam <festevam@...il.com>,
	Alexandre Bounine <alexandre.bounine@....com>,
	paul.gortmaker@...driver.com, dan.j.williams@...el.com,
	samuel@...tiz.org, lrg@...com, perex@...ex.cz, tiwai@...e.de,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	netdev@...r.kernel.org, fabio.estevam@...escale.com,
	alsa-devel@...a-project.org
Subject: Re: [PATCH linux-next] dmaengine: add context parameter fixups

On Mon, 2012-03-26 at 11:33 +0100, Mark Brown wrote:
> On Mon, Mar 26, 2012 at 03:24:30PM +0530, Vinod Koul wrote:
> 
> > Now either I drop these from 3.4 or merge Linus's tree and apply
> > Alexandre's fix (as that is the right fix rather than one in asoc tree)
> > And since this was required for RIO patches which are still WIP, I think
> > I am leaning towards former.
> 
> Gah, WTF is going on here?  Has this API change not been sent to Linus
> already, and what is wrong with the changes which Fabio sent?  I've
> already applied Fabio's change on the understanding that this API change
> done and dusted.
> 
> It seems better to do a minimal fix at this point rather than churning
> things again...

The change is technically correct, so don't worry it wont break
anything, and API is frozen and not changing.

But we don't want the clients to use this additional parameter or be
exposed to it if not required. Every client is expected to use the
dmaengine wrappers for prepare and not invoke .device_ callbacks.


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html