netdev - Re: [PATCH V2 4/7] net/mlx4_en: Set max rate-limit for a TC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332773163.3500.81.camel@deadeye>
Date:	Mon, 26 Mar 2012 15:46:03 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Amir Vadai <amirv@...lanox.com>
CC:	"David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
	Roland Dreier <roland@...estorage.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Oren Duer <oren@...lanox.com>,
	Amir Vadai <amirv@....mellanox.co.il>
Subject: Re: [PATCH V2 4/7] net/mlx4_en: Set max rate-limit for a TC

On Mon, 2012-03-26 at 11:07 +0200, Amir Vadai wrote:
> Set max rate-limit using sysfs file /sys/class/net/<interface>/ratelimit/tc<n>
> Values in Mbps units.
> 
> For example, to set ratelimit of 5G to TC3 issue:
> echo 5000 > /sys/class/net/eth2/ratelimit/tc3

This looks the wrong way round; wouldn't a tc be an object with a
ratelimit as attribute?

> Signed-off-by: Amir Vadai <amirv@...lanox.com>
> ---
> 
> We used sysfs since max bw isn't part of the ETS / DCBX NL support, and we're
> open to other suggestions to add generic support for max bw, e.g add call to
> the DCBX NL API.
[...]

netlink interfaces are generally easily extensible and it doesn't make
sense to me to augment such an interface through sysfs.  Perhaps you're
concerned that netlink extensions won't be supported in older kernel
versions running your OOT driver?  That's unfortunate, but let's not
standardise an ugly interface based on a temporary problem like that.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html