netdev - Re: [PATCH V2 4/7] net/mlx4_en: Set max rate-limit for a TC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZKGJ_nJt92THc+eRGnEXPZG+hX_d2=f56m7gB_Fv8K4Cg@mail.gmail.com>
Date:	Mon, 26 Mar 2012 19:00:34 +0200
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>
Cc:	Amir Vadai <amirv@...lanox.com>, netdev@...r.kernel.org,
	Roland Dreier <roland@...estorage.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Oren Duer <oren@...lanox.com>,
	Amir Vadai <amirv@....mellanox.co.il>
Subject: Re: [PATCH V2 4/7] net/mlx4_en: Set max rate-limit for a TC

On Mon, Mar 26, 2012 at 4:46 PM, Ben Hutchings
<bhutchings@...arflare.com> wrote:
>> We used sysfs since max bw isn't part of the ETS / DCBX NL support, and we're
>> open to other suggestions to add generic support for max bw, e.g add call to
>> the DCBX NL API.

> netlink interfaces are generally easily extensible and it doesn't make
> sense to me to augment such an interface through sysfs.  Perhaps you're
> concerned that netlink extensions won't be supported in older kernel
> versions running your OOT driver?  That's unfortunate, but let's not
> standardise an ugly interface based on a temporary problem like that.

As written above, that was done since ratelimit isn't part of ETS, we can
that through netlink extensions that you mentioned, if this is the preffered
way to go, David? Eric? Ben - could you provide pointer to these extensions?

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html