netdev - Re: a F-RTO question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJkE24JXgOtbybWozeq8XKvQy9qUbJDKjcYEtaSWr3pP+ESciQ@mail.gmail.com>
Date:	Wed, 28 Mar 2012 13:27:00 +0800
From:	Chao Pei <peichao85@...il.com>
To:	Li Yu <raise.sail@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: a F-RTO question

>
>>> Hi,
>>>
>>>        I have a question about tcp_process_frto(), the below source
>>> code :
>>>
>>> static int tcp_process_frto(struct sock *sk, int flag)
>>> {
>>>        .....
>>>
>>>        if (!before(tp->snd_una, tp->frto_highmark)) {
>>>                tcp_enter_frto_loss(sk, ...);
>>>                return 1;
>>>        }
>>>
>>>        .....
>>>
>>> }
>>>
>>>        As my understanding, the tp->frto_highmark likes tp->high_seq,
>>> it saves the seqno SND_NXT when a TCP connection enters F-RTO phase,
>>> is it the variable "recovery" in NewReno? So I think that if snd_una is
>>> equal with or after frto_highmark, which means peer ack new data, so
>>> why we enter Loss state here?
>>>
>>>        Thanks!
>>>
>>> Yu
>>>
>>>
>>
>> If snd_una advances to frto_highmark, it is likely that the hole was
>> filled by the retransimitted packet, which means the original packet
>> was likely to have been lost.
>> So, we should enter loss state.
>>
>
> I do not agree with it, if snd_una advanced to frto_highmark, which means
> peer acks whole window of data instead of just one segment, and
> we can not make sure that reason of peer sends ack is whether it received
> original segment or retransmitted segment.
>
> Even, the reason is latter, it also means the netowrk already is
> recovered from temporarily congestion or disordered state, so we also should
> not enter loss state.
>
> Thanks
>
> Yu
>

If it is for the first reason, then the receiver should not ack the
whole rtt of packets with just one ack. Instead, it should send ack
once every second packet. So, we can almost be sure that the original
packet was lost.

As for the second question. I think since the loss is proven and was
actually detected because of the RTO timer, we should enter loss
state.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html