netdev - Re: [PATCH] tcp: remove useless update for flag parameter in tcp_enter_frto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK6E8=fFfU=53U8KxPRgxPhhaCMv+1R+z0EtVHQd=6S9Gcy5tg@mail.gmail.com>
Date:	Tue, 27 Mar 2012 22:27:09 -0700
From:	Yuchung Cheng <ycheng@...gle.com>
To:	Li Yu <raise.sail@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: remove useless update for flag parameter in tcp_enter_frto_loss()

On Tue, Mar 27, 2012 at 9:23 PM, Li Yu <raise.sail@...il.com> wrote:
>
> It seem that we forget remove below two lines after copying code :)
>
> This update never impacts others.
>
> Sorry for last mail with legal notices improperly, I used wrong
> mail.
>
> Signed-off-by Li Yu <bingtian.ly@...bao.com>
>
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index e886e2f..b2f8ada 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -2169,8 +2169,6 @@ static void tcp_enter_frto_loss(struct sock *sk,
> int allowed_segments, int flag)
>                        /* For some reason this R-bit might get cleared? */
>                        if (TCP_SKB_CB(skb)->sacked & TCPCB_SACKED_RETRANS)
>                                tp->retrans_out += tcp_skb_pcount(skb);
> -                       /* ...enter this if branch just for the first segment */
> -                       flag |= FLAG_DATA_ACKED;

The comment explicitly explains why the flag is marked for.


>                } else {
>                        if (TCP_SKB_CB(skb)->sacked & TCPCB_RETRANS)
>                                tp->undo_marker = 0;
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html