netdev - Re: [PATCH] ipv6: fix array index in ip6_mc_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Apr 2012 16:19:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: fix array index in ip6_mc_add_src()

From: RongQing Li <roy.qing.li@...il.com>
Date: Mon, 2 Apr 2012 18:16:14 +0800

> 2012/4/2 David Miller <davem@...emloft.net>:
>> From: roy.qing.li@...il.com
>> Date: Sun,  1 Apr 2012 16:45:26 +0800
>>
>>> From: RongQing.Li <roy.qing.li@...il.com>
>>>
>>> Convert array index from the loop bound to the loop index.
>>>
>>> Signed-off-by: RongQing.Li <roy.qing.li@...il.com>
>>
>> That's not all you are doing:
>>
>>> -                     (void) ip6_mc_del1_src(pmc, sfmode, &psfsrc[i]);
>>> +                     ip6_mc_del1_src(pmc, sfmode, &psfsrc[j]);
>>
>> You absolutely MUST mention and explain this (void) removal.
>> It's probably there to elide an unchecked return value
>> warning from the compiler.
> 
> since ip6_mc_del1_src() does not use __must_check likely attribute.
> I try to compile with several gcc warning options, but do not
> find which options can report the unchecked return value.

I said "probably", I didn't check myself.

The issue I had was that you didn't mention the void removal in the
commit message.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html