netdev - Re: [net-next 3/3] ixgbe: add syfs interface for to export read only driver information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Apr 2012 18:49:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	florian@...nwrt.org, jeffrey.t.kirsher@...el.com,
	donald.c.skidmore@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 3/3] ixgbe: add syfs interface for to export read
 only driver information

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 5 Apr 2012 17:32:05 +0100

> On Thu, 2012-04-05 at 14:19 +0200, Florian Fainelli wrote:
>> Hi,
>> 
>> Le 04/05/12 12:47, Jeff Kirsher a écrit :
>> > From: Don Skidmore<donald.c.skidmore@...el.com>
>> >
>> > This patch exports non-thermal (which was done via hwmon in an earlier
>> > patch) data to syfs.  All of the fields are read only as this interface
>> > is to only export driver data.
>> >
>> > Signed-off-by: Don Skidmore<donald.c.skidmore@...el.com>
>> > Tested-by: Stephen Ko<stephen.s.ko@...el.com>
>> > Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@...el.com>
>> > ---
>> 
>> I only looked briefly at the exported attributes, but most of them can 
>> already be queried using ethtool, can't they?
> [...]
> 
> I agree, it looks like most of these are:
> 
> (1) already exposed through ethtool commands (ETHTOOL_GSET,
> ETHTOOL_GDRVINFO, ETHTOOL_GLINK and ETHTOOL_GPERMADDR), or
> (2) already exposed through rtnetlink or the net device in sysfs, or
> (3) statistics that should be exposed through ETHTOOL_GSTATS
> 
> I imagine there are some that don't fall into those categories, but I
> don't see why they should *all* be exposed in a non-standard and/or
> redundant way.

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html