netdev - RE: [net-next 3/3] ixgbe: add syfs interface for to export read only driver information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F6FB0E698C9B3143BDF729DF222866460F58D4FE@FMSMSX151.amr.corp.intel.com>
Date:	Thu, 5 Apr 2012 23:01:32 +0000
From:	"Skidmore, Donald C" <donald.c.skidmore@...el.com>
To:	David Miller <davem@...emloft.net>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>
CC:	"florian@...nwrt.org" <florian@...nwrt.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [net-next 3/3] ixgbe: add syfs interface for to export read
 only driver information

>-----Original Message-----
>From: David Miller [mailto:davem@...emloft.net]
>Sent: Thursday, April 05, 2012 3:50 PM
>To: bhutchings@...arflare.com
>Cc: florian@...nwrt.org; Kirsher, Jeffrey T; Skidmore, Donald C;
>netdev@...r.kernel.org; gospo@...hat.com; sassmann@...hat.com
>Subject: Re: [net-next 3/3] ixgbe: add syfs interface for to export read
>only driver information
>
>From: Ben Hutchings <bhutchings@...arflare.com>
>Date: Thu, 5 Apr 2012 17:32:05 +0100
>
>> On Thu, 2012-04-05 at 14:19 +0200, Florian Fainelli wrote:
>>> Hi,
>>>
>>> Le 04/05/12 12:47, Jeff Kirsher a écrit :
>>> > From: Don Skidmore<donald.c.skidmore@...el.com>
>>> >
>>> > This patch exports non-thermal (which was done via hwmon in an
>earlier
>>> > patch) data to syfs.  All of the fields are read only as this
>interface
>>> > is to only export driver data.
>>> >
>>> > Signed-off-by: Don Skidmore<donald.c.skidmore@...el.com>
>>> > Tested-by: Stephen Ko<stephen.s.ko@...el.com>
>>> > Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@...el.com>
>>> > ---
>>>
>>> I only looked briefly at the exported attributes, but most of them
>can
>>> already be queried using ethtool, can't they?
>> [...]
>>
>> I agree, it looks like most of these are:
>>
>> (1) already exposed through ethtool commands (ETHTOOL_GSET,
>> ETHTOOL_GDRVINFO, ETHTOOL_GLINK and ETHTOOL_GPERMADDR), or
>> (2) already exposed through rtnetlink or the net device in sysfs, or
>> (3) statistics that should be exposed through ETHTOOL_GSTATS
>>
>> I imagine there are some that don't fall into those categories, but I
>> don't see why they should *all* be exposed in a non-standard and/or
>> redundant way.
>
>Agreed.

Thanks for the input.  I'll start on refactoring the patch to exclude all items that are exposed in any other way.

-Don Skidmore <donald.c.skidmore@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html