netdev - Re: [PATCH net-next #2 10/39] fealnx: stop using net_device.{base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120406.062147.2000030375239361962.davem@davemloft.net>
Date:	Fri, 06 Apr 2012 06:21:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next #2 10/39] fealnx: stop using
 net_device.{base_addr, irq}.

From: Francois Romieu <romieu@...zoreil.com>
Date: Fri,  6 Apr 2012 12:06:24 +0200

> -	if (request_irq(dev->irq, intr_handler, IRQF_SHARED, dev->name, dev))
> -		return -EAGAIN;
> +	rc = request_irq(irq, intr_handler, IRQF_SHARED, dev->name, dev);
> +	if (rc < 0)
> +		goto out;

Please at least preserve the test, make it "if (rc)"
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html