netdev - Re: [PATCH net-next #2 27/39] smsc9420: stop using net_device.{base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120406.062351.247404412856760540.davem@davemloft.net>
Date:	Fri, 06 Apr 2012 06:23:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	netdev@...r.kernel.org, steve.glendinning@...c.com
Subject: Re: [PATCH net-next #2 27/39] smsc9420: stop using
 net_device.{base_addr, irq}.

From: Francois Romieu <romieu@...zoreil.com>
Date: Fri,  6 Apr 2012 12:06:41 +0200

> -	if (request_irq(dev->irq, smsc9420_isr, IRQF_SHARED | IRQF_DISABLED,
> -			DRV_NAME, pd)) {
> -		smsc_warn(IFUP, "Unable to use IRQ = %d", dev->irq);
> -		result = -ENODEV;
> +	result = request_irq(irq, smsc9420_isr, IRQF_SHARED | IRQF_DISABLED,
> +			     DRV_NAME, pd);
> +	if (result < 0) {
> +		smsc_warn(IFUP, "Unable to use IRQ = %d", irq);

Another case where you should preserve the nature of
the test, make this "if (result)"
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html