netdev - Re: [PATCH net-next #2 32/39] epic100: stop using net_device.{base_addr, irq} and convert to _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120406.062510.1292136785820320926.davem@davemloft.net>
Date:	Fri, 06 Apr 2012 06:25:10 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next #2 32/39] epic100: stop using
 net_device.{base_addr, irq} and convert to __iomem.

From: Francois Romieu <romieu@...zoreil.com>
Date: Fri,  6 Apr 2012 12:06:46 +0200

>  	napi_enable(&ep->napi);
> -	if ((retval = request_irq(dev->irq, epic_interrupt, IRQF_SHARED, dev->name, dev))) {
> +	rc = request_irq(irq, epic_interrupt, IRQF_SHARED, dev->name, dev);
> +	if (rc < 0) {

Please preserve the test: "if (rc)"
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html