netdev - Re: [PATCH v2 1/2] netfilter: ipvs: Verify that IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Apr 2012 15:23:32 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Sasha Levin <levinsasha928@...il.com>
cc:	wensong@...ux-vs.org, horms@...ge.net.au, kaber@...sh.net,
	davem@...emloft.net, davej@...hat.com, netdev@...r.kernel.org,
	lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] netfilter: ipvs: Verify that IP_VS protocol has
 been registered


	Hello,

On Sat, 14 Apr 2012, Sasha Levin wrote:

> On Sat, Apr 14, 2012 at 1:53 PM, Julian Anastasov <ja@....bg> wrote:
> >        Ops. It seems now we expose old problem when
> > no protocol is configured. As this change probably will
> > go to stable kernels, lets make it correct. Can you
> > remove the defines around register_ip_vs_proto_netns, so
> > that it is always compiled. One that wants to save
> > memory will not disable all protocols. See commit
> > 091bb34c143674d37a59b2d4857534f7106c5d7d for reference.
> 
> Oh, so it wasn't getting built right now at all if we didn't select
> any protocols.
> 
> How about moving those defines down to our loop as well? this way
> everything will behave exactly like it did before.

	Better to remove the defines. It is a misconfiguration
to enable IPVS without protocols. The referenced commit
just tried to remove warnings, not save memory by commenting
unused function. Adding more define makes the things more ugly.

Regards

--
Julian Anastasov <ja@....bg>