netdev - Re: [PATCH v2] bonding: start slaves with link down for ARP monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2570606.YH3Fgdn9ql@alaris>
Date:	Wed, 18 Apr 2012 14:32:31 +0200
From:	Michal Kubeček <mkubecek@...e.cz>
To:	Jay Vosburgh <fubar@...ibm.com>
Cc:	Flavio Leitner <fbl@...hat.com>, netdev@...r.kernel.org,
	Andy Gospodarek <andy@...yhouse.net>
Subject: Re: [PATCH v2] bonding: start slaves with link down for ARP monitor

On Tuesday 17 of April 2012 13:58EN, Michal Kubeček wrote:
> On Monday 16 of April 2012 12:27EN, Michal Kubeček wrote:
> > On Saturday 14 of April 2012 21:48EN, Jay Vosburgh wrote:
> > > Anybody got a 10 or 100 card laying around with fast autoneg to
> > > try?  Back in the day I used 3c59x and e100s, and I seem to recall
> > > that the 3c59x board I had was pretty speedy at going carrier up.
> > 
> > It seems these cards are hard to find these days (I tried to find
> > one
> > in our office but no luck yet). However, I tried an onboard adapter
> > with r8169 driver and patched kernel succeeded to detect carrier in
> > time for bonding driver to start the slave in "up" state (and it
> > started in "down" state with unplugged cable so that the detection
> > is
> > correct).
> 
> I tested few more cards:
> 
> - two 100 Mb/s Realtek 8139C and 8139D with 8139too driver:
>   driver sets carrier on soon enough and slave starts with "up" and
>   stays that way (same as r8169)
> 
> - 1 Gb/s Intel Pro/1000PT (82572EI) with e1000e driver:
>   essentially the same as igb, driver is slow and patch prevents the
>   up -> down -> up sequence by starting the slave in "down" state
> 
> - 100 Mb/s Intel (?) cards with DECchip Tulip 21142/3, tulip driver:
>   card/driver either doesn't set the flag properly or is extremely
> slow with up -> down transition so that the state was "up" all the
> time no matter what the real link state was

Thanks to Andreas Taschner, I could test some more cards, including 
3COM:

- both 3COM's (3C905CX and 3C595 with 3c59x driver) reset the flag fast
  enough for bonding to detect "up" from the start

- e100 (Compaq NC3120) took about 46 ms which was too late and slave
  started in "down", waiting for ARP monitor

- Marvell 88E8001 (skge driver) needs 2-3 seconds so that the patch
  prevented spurious failure

All tested cards can be divided into three groups:

1. patch helps: igb, e1000e, skge
2. no change: r8169, 8139too, 3c59x, tulip
3. delay introduced: e100

(I also tested a virtual e1000 in VMware Workstation guest, it falls 
into group 2 - initial detection fast enough.)

IMHO the cards currently in use are much more likely to fall into first 
group than into third.

                                                         Michal Kubecek

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html