netdev - Re: [PATCH net-next 2/5] be2net: Fix to allow setting of debug levels in the firmware.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1335461388.2712.25.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Thu, 26 Apr 2012 18:29:48 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Somnath Kotur <Somnath.Kotur@...lex.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/5] be2net: Fix to allow setting of debug
 levels in the firmware.

On Thu, 2012-04-26 at 19:57 +0530, Somnath Kotur wrote:
> From: Somnath Kotur <somnath.kotur@...lex.com>
[...]
> @@ -893,6 +959,7 @@ const struct ethtool_ops be_ethtool_ops = {
>  	.set_pauseparam = be_set_pauseparam,
>  	.get_strings = be_get_stat_strings,
>  	.set_phys_id = be_set_phys_id,
> +	.set_msglevel = be_set_msglevel,
>  	.get_sset_count = be_get_sset_count,
>  	.get_ethtool_stats = be_get_ethtool_stats,
>  	.get_regs_len = be_get_reg_len,

This operation is intended for controlling logging by the driver, and
the flags are defined in <linux/netdevice.h>.  (Not exported to userland
yet, but ethtool knows their names.)

If your firmware supports some kind of logging then it may be reasonable
to have this control both driver and firmware, but not *just* the
firmware.

You should also implement the get_msglevel operation at the same time.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html