netdev - RE: [PATCH net-next 2/5] be2net: Fix to allow setting of debug levels in the firmware.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3367B80B08154D42A3B2BC708B5D41F6440F8979D6@EXMAIL.ad.emulex.com>
Date:	Thu, 26 Apr 2012 23:46:06 -0700
From:	<Somnath.Kotur@...lex.Com>
To:	<bhutchings@...arflare.com>
CC:	<netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 2/5] be2net: Fix to allow setting of debug
 levels in the firmware.

> > This operation is intended for controlling logging by the driver, and the flags
> are defined in <linux/netdevice.h>.  (Not exported to userland yet, but
> ethtool knows their names.)
> 
> If your firmware supports some kind of logging then it may be reasonable to
> have this control both driver and firmware, but not *just* the firmware.
Thanks for your comments Ben.

Currently the driver logs only a very few critical errors/warnings; so we felt it might be an overkill to 
define driver log levels.
On the other hand, the F/W has extensive logging and tracing facility and the ethtool 'msglevel' option seemed 
like a reasonable method for controlling the logging level.

> 
> You should also implement the get_msglevel operation at the same time.

Yes you are correct. We will implement the get_msglevel and re-post the patch.
> 
> Ben.
> 

Thanks
Som