netdev - RE: [PATCH net-next 3/5] be2net: Fix to apply duplex value as unknown when link is down.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 26 Apr 2012 23:42:38 -0700
From:	<Somnath.Kotur@...lex.Com>
To:	<bhutchings@...arflare.com>
CC:	<netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 3/5] be2net: Fix to apply duplex value as
 unknown when link is down.

 > I don't see any problem with reporting full-duplex all the time if you don't
> support any half-duplex link modes.  But we don't yet have consistency
> between drivers in speed/duplex reporting while the link is down, so I won't
> insist that that is the right thing to do.
> 
> However you should use DUPLEX_UNKNOWN rather than -1.
> 
> Ben.

Yes, Agreed. Thank you for your review/suggestion.

Will make the change and re-post.

-Som.

> --
> Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer;
> that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.