lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120501155747.368a1d36.akpm@linux-foundation.org> Date: Tue, 1 May 2012 15:57:47 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Mel Gorman <mgorman@...e.de> Cc: Linux-MM <linux-mm@...ck.org>, Linux-Netdev <netdev@...r.kernel.org>, Linux-NFS <linux-nfs@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, David Miller <davem@...emloft.net>, Trond Myklebust <Trond.Myklebust@...app.com>, Neil Brown <neilb@...e.de>, Christoph Hellwig <hch@...radead.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Mike Christie <michaelc@...wisc.edu>, Eric B Munson <emunson@...bm.net> Subject: Re: [PATCH 05/11] mm: swap: Implement generic handler for swap_activate On Mon, 16 Apr 2012 13:17:49 +0100 Mel Gorman <mgorman@...e.de> wrote: > The version of swap_activate introduced is sufficient for swap-over-NFS > but would not provide enough information to implement a generic handler. > This patch shuffles things slightly to ensure the same information is > available for aops->swap_activate() as is available to the core. > > No functionality change. > > ... > > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -587,6 +587,8 @@ typedef struct { > typedef int (*read_actor_t)(read_descriptor_t *, struct page *, > unsigned long, unsigned long); > > +struct swap_info_struct; Please put forward declarations at top-of-file. To prevent accidental duplication later on. > struct address_space_operations { > int (*writepage)(struct page *page, struct writeback_control *wbc); > int (*readpage)(struct file *, struct page *); > > ... > > --- a/mm/page_io.c > +++ b/mm/page_io.c Have you tested all this code with CONFIG_SWAP=n? Have you sought to minimise additional new code when CONFIG_SWAP=n? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists