lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 May 2012 12:33:53 -0400 (EDT) From: David Miller <davem@...emloft.net> To: joe@...ches.com Cc: jussi.kivilinna@...et.fi, linville@...driver.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org Subject: Re: [PATCH 1/3] drivers/net: Convert compare_ether_addr to ether_addr_equal From: Joe Perches <joe@...ches.com> Date: Thu, 10 May 2012 09:11:28 -0700 > (cc's trimmed) > > On Thu, 2012-05-10 at 17:32 +0300, Jussi Kivilinna wrote: >> Quoting Joe Perches <joe@...ches.com>: >> > Use the new bool function ether_addr_equal to add >> > some clarity and reduce the likelihood for misuse >> > of compare_ether_addr for sorting. > [] >> > diff --git a/drivers/net/wireless/rndis_wlan.c > [] >> > @@ -2139,7 +2139,7 @@ resize_buf: >> > while (check_bssid_list_item(bssid, bssid_len, buf, len)) { >> > if (rndis_bss_info_update(usbdev, bssid) && match_bssid && >> > matched) { >> > - if (compare_ether_addr(bssid->mac, match_bssid)) >> > + if (!ether_addr_equal(bssid->mac, match_bssid)) >> >> While reviewing this, noticed that above original code is wrong. It >> should be !compare_ether_addr. So do I push patch fixing this through >> wireless-testing althought it will later cause conflict with this patch? >> >> -Jussi >> >> > *matched = true; >> > } >> > > > Up to John. > > Here's the patch I would send against net-next > updating the test and the style a little. I think in this specific case it's better to push this one directly through net-next. But yes, it's up to John. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists