netdev - Re: pull request: batman-adv 2012-05-11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120511.180144.174337959525316777.davem@davemloft.net>
Date:	Fri, 11 May 2012 18:01:44 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ordex@...istici.org
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: pull request: batman-adv 2012-05-11

From: Antonio Quartulli <ordex@...istici.org>
Date: Fri, 11 May 2012 14:21:17 +0200

> this is a fixed version of the pull request issued on 2012-05-09.
> 
> Comments introduced in this patchset are not following the net-tree
> guidelines. Another patch changing all the already existing comments will follow
> later. 
> 
> New exported functions follow the new name convention we discussed so far.
> A patch renaming all the existing exported functions will follow.

Pulled, but you have to cleanup the namespace on lots of other
functions too.

For example, the packet receive handle register/unregister routines
you added in this series as well.

Go through the entire batman-adv stack, and if the function or data
object is not static, make sure it has a batadv_*() prefix.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html