[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B6F0B@saturn3.aculab.com>
Date: Mon, 14 May 2012 15:19:49 +0100
From: "David Laight" <David.Laight@...LAB.COM>
To: <pablo@...filter.org>, <netfilter-devel@...r.kernel.org>
Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: RE: [PATCH 1/4] netfilter: ipset: fix timeout value overflow bug
> --- a/include/linux/netfilter/ipset/ip_set_timeout.h
> +++ b/include/linux/netfilter/ipset/ip_set_timeout.h
> @@ -30,6 +30,10 @@ ip_set_timeout_uget(struct nlattr *tb)
> {
> unsigned int timeout = ip_set_get_h32(tb);
>
> + /* Normalize to fit into jiffies */
> + if (timeout > UINT_MAX/1000)
> + timeout = UINT_MAX/1000;
> +
Doesn't that rather assume that HZ is 1000 ?
David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists