netdev - Re: [PATCH net-next v2 0/2] 6lowpan: code updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120516.152801.915753046212672140.davem@davemloft.net>
Date:	Wed, 16 May 2012 15:28:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	alex.bluesman.smirnov@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/2] 6lowpan: code updates

From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Date: Wed, 16 May 2012 11:27:26 +0400

>   6lowpan: rework data fetching from skb

This is not what we told you to do.

We told you that IF you were going to emit a warning message
for the pskb_may_pull() failure condition, you should use
WARN_ON_ONCE() so that it doesn't potentially flood the
logs.

But you must always, in every case, handle the error in some
reasonable way, not just when WARN_ON_ONCE() does that initial
one-and-only trigger.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html