[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJmB2rAVwSNmkjFWuZBgDVMLKa=T3H5TwoEYHxfMnDecSgGsmA@mail.gmail.com>
Date: Thu, 17 May 2012 11:31:34 +0400
From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
To: David Miller <davem@...emloft.net>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/2] 6lowpan: code updates
Got it!
Damn, my fault, sorry for that.
Alex
2012/5/16 David Miller <davem@...emloft.net>:
> From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
> Date: Wed, 16 May 2012 11:27:26 +0400
>
>> 6lowpan: rework data fetching from skb
>
> This is not what we told you to do.
>
> We told you that IF you were going to emit a warning message
> for the pskb_may_pull() failure condition, you should use
> WARN_ON_ONCE() so that it doesn't potentially flood the
> logs.
>
> But you must always, in every case, handle the error in some
> reasonable way, not just when WARN_ON_ONCE() does that initial
> one-and-only trigger.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists