lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4FD75138.2090503@st.com> Date: Tue, 12 Jun 2012 16:24:56 +0200 From: Giuseppe CAVALLARO <peppe.cavallaro@...com> To: Yuval Mintz <yuvalmin@...adcom.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "bhutchings@...arflare.com" <bhutchings@...arflare.com>, "rayagond@...avyalabs.com" <rayagond@...avyalabs.com>, "davem@...emloft.net" <davem@...emloft.net> Subject: Re: [net-next.git 4/4 (v4)] stmmac: add the Energy Efficient Ethernet support On 6/12/2012 3:09 PM, Yuval Mintz wrote: > Hi Giuseppe, > >> @@ -1541,10 +1663,37 @@ static irqreturn_t stmmac_interrupt(int irq, >> void *dev_id) >> + if (unlikely(status)) { >> + if (status & core_mmc_tx_irq) >> + priv->xstats.mmc_tx_irq_n++; >> + if (status & core_mmc_rx_irq) >> + priv->xstats.mmc_rx_irq_n++; >> + if (status & core_mmc_rx_csum_offload_irq) >> + priv->xstats.mmc_rx_csum_offload_irq_n++; >> + if (status & core_irq_receive_pmt_irq) >> + priv->xstats.irq_receive_pmt_irq_n++; >> + > > Are these EEE related? > >> + /* To handle DMA interrupts */ > > Is this related? > To clearly manage and expose the lpi interrupt status and eee ethtool stats I've had to do some modifications to the driver's design and I found really useful to move other parts of the code (e.g. mmc irq stat) in the main directly. So this just is the result of a complete reworking made to introduce the EEE. I could better document it in the patch's comment or create a separate patch that could take a while. Cheers Peppe > > Cheers, > Yuval Mintz > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists