netdev - Re: [net-next.git 2/4] stmmac: do not use strict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339511281.22704.156.camel@edumazet-glaptop>
Date:	Tue, 12 Jun 2012 16:28:01 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com,
	rayagond@...avyalabs.com, davem@...emloft.net,
	yuvalmin@...adcom.com
Subject: Re: [net-next.git 2/4] stmmac: do not use strict_strtoul but
 kstrtoul

On Tue, 2012-06-12 at 14:45 +0200, Giuseppe CAVALLARO wrote:
> This patch replaces the obsolete strict_strtoul with kstrtoul.
> 
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |   26 ++++++++-------------
>  1 files changed, 10 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 8899e10..e33abf5 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2126,42 +2126,36 @@ static int __init stmmac_cmdline_opt(char *str)
>  		return -EINVAL;
>  	while ((opt = strsep(&str, ",")) != NULL) {
>  		if (!strncmp(opt, "debug:", 6)) {
> -			if (strict_strtoul(opt + 6, 0, (unsigned long *)&debug))
> +			if (kstrtoul(opt + 6, 0, (unsigned long *)&debug))
>  				goto err;


int debug;
...
if (kstrtoul(opt + 6, 0, (unsigned long *)&debug))

Please get rid of these wrong casts.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html