lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Jun 2012 09:34:29 +0800 From: Fan Du <fan.du@...driver.com> To: Steffen Klassert <steffen.klassert@...unet.com> CC: <davem@...emloft.net>, <herbert@...dor.hengli.com.au>, <netdev@...r.kernel.org>, <fdu@...driver.com> Subject: Re: [PATCH] [XFRM] Fix unexpected SA hard expiration after changing date On 2012年06月18日 19:05, Steffen Klassert wrote: > On Mon, Jun 18, 2012 at 04:24:16PM +0800, fan.du wrote: >> After SA is setup, one timer is armed to detect soft/hard expiration, >> however the timer handler uses xtime to do the math. This makes hard >> expiration occurs first before soft expiration after setting new date >> with big interval. As a result new child SA is deleted before rekeying >> the new one. >> >> Signed-off-by: fan.du<fan.du@...driver.com> >> --- >> include/net/xfrm.h | 2 ++ >> net/xfrm/xfrm_state.c | 22 ++++++++++++++++++---- >> 2 files changed, 20 insertions(+), 4 deletions(-) >> >> diff --git a/include/net/xfrm.h b/include/net/xfrm.h >> index 2933d74..1734acc 100644 >> --- a/include/net/xfrm.h >> +++ b/include/net/xfrm.h >> @@ -214,6 +214,8 @@ struct xfrm_state >> /* Private data of this transformer, format is opaque, >> * interpreted by xfrm_type methods. */ >> void *data; >> + u32 flags; > > We already have the xflags field, it holds exactly one flag > at the moment. So I think we don't need yet another u32 that > holds one flag too. > good point! I will make it in the next version. -- Love each day! --fan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists