netdev - Re: [PATCH] ipv6: Move ipv6 proc file registration to end of init order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120618.183916.1295267206223791197.davem@davemloft.net>
Date:	Mon, 18 Jun 2012 18:39:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: Move ipv6 proc file registration to end of init
 order

From: Thomas Graf <tgraf@...g.ch>
Date: Tue, 19 Jun 2012 00:08:33 +0200

> /proc/net/ipv6_route reflects the contents of fib_table_hash. The proc
> handler is installed in ip6_route_net_init() whereas fib_table_hash is
> allocated in fib6_net_init() _after_ the proc handler has been installed.
> 
> This opens up a short time frame to access fib_table_hash with its pants
> down.
> 
> Move the registration of the proc files to a later point in the init
> order to avoid the race.
> 
> Tested :-)
> 
> Signed-off-by: Thomas Graf <tgraf@...g.ch>

This looks a lot better, applied, thanks Thomas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html