netdev - Re: [PATCH net-next 2/6] bnx2x: link cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340204019.29885.9.camel@joe2Laptop>
Date:	Wed, 20 Jun 2012 07:53:39 -0700
From:	Joe Perches <joe@...ches.com>
To:	Yuval Mintz <yuvalmin@...adcom.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, eilong@...adcom.com,
	Yaniv Rosner <yaniv.rosner@...adcom.com>
Subject: Re: [PATCH net-next 2/6] bnx2x: link cleanup

On Wed, 2012-06-20 at 11:49 +0300, Yuval Mintz wrote:
> This patch does several things:
[]
>  3. Change msleep(1) --> usleep_range(1000, 1000)

I believe replacing msleep(small) with
usleep_range(small * 1000, small * 1000) is
not generally a good idea.

Please give usleep_range an actual range to
work with and not a repeated single value.

Please think a little more about what a
good upper range for the maximum time to
sleep should be.

usleep_range(small * 1000, small * 2000)
or something similar maybe.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html