netdev - RE: [PATCH net-next 2/6] bnx2x: link cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Jun 2012 17:50:23 +0000
From:	"Yuval Mintz" <yuvalmin@...adcom.com>
To:	"Joe Perches" <joe@...ches.com>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Eilon Greenstein" <eilong@...adcom.com>,
	"Yaniv Rosner" <yaniv.rosner@...adcom.com>
Subject: RE: [PATCH net-next 2/6] bnx2x: link cleanup

> >  3. Change msleep(1) --> usleep_range(1000, 1000)
> 
> I believe replacing msleep(small) with
> usleep_range(small * 1000, small * 1000) is
> not generally a good idea.
> 
> Please give usleep_range an actual range to
> work with and not a repeated single value.
> 
> Please think a little more about what a
> good upper range for the maximum time to
> sleep should be.
> 
> usleep_range(small * 1000, small * 2000)
> or something similar maybe.
>

Sounds good.  I'll change it and re-send the patch series.

Thanks,
Yuval Mintz