netdev - Re: [net] ixgbe: simplify padding and length checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340314089.2033.16.camel@jtkirshe-mobl>
Date:	Thu, 21 Jun 2012 14:28:09 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com
Subject: Re: [net] ixgbe: simplify padding and length checks

On Thu, 2012-06-21 at 13:38 -0700, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Thu, 21 Jun 2012 05:15:10 -0700
> 
> > From: Stephen Hemminger <shemminger@...tta.com>
> > 
> > The check for length <= 0 is bogus because length is unsigned, and network
> > stack never sends zero length packets (unless it is totally broken).
> > 
> > The check for really small packets can be optimized (using unlikely)
> > and calling skb_pad directly.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> > Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> Not really fixing anything and more of a cleanup, so maybe 'net-next'
> instead of 'net' for this guy instead?

Yeah, net-next is fine.  I just verified that the patch applies cleanly
to net-next as well.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)