| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120621.150454.828540055288845272.davem@davemloft.net> Date: Thu, 21 Jun 2012 15:04:54 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jeffrey.t.kirsher@...el.com Cc: shemminger@...tta.com, netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com Subject: Re: [net] ixgbe: simplify padding and length checks From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Date: Thu, 21 Jun 2012 14:28:09 -0700 > On Thu, 2012-06-21 at 13:38 -0700, David Miller wrote: >> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> >> Date: Thu, 21 Jun 2012 05:15:10 -0700 >> >> > From: Stephen Hemminger <shemminger@...tta.com> >> > >> > The check for length <= 0 is bogus because length is unsigned, and network >> > stack never sends zero length packets (unless it is totally broken). >> > >> > The check for really small packets can be optimized (using unlikely) >> > and calling skb_pad directly. >> > >> > Signed-off-by: Stephen Hemminger <shemminger@...tta.com> >> > Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com> >> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com> >> >> Not really fixing anything and more of a cleanup, so maybe 'net-next' >> instead of 'net' for this guy instead? > > Yeah, net-next is fine. I just verified that the patch applies cleanly > to net-next as well. Great, applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists