netdev - Re: [PATCH 4/6] mac80211: clean up debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340376203.4491.29.camel@jlt3.sipsolutions.net>
Date:	Fri, 22 Jun 2012 16:43:23 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-wireless@...r.kernel.org, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 4/6] mac80211: clean up debugging

On Fri, 2012-06-22 at 07:37 -0700, Joe Perches wrote:
> On Fri, 2012-06-22 at 15:14 +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@...el.com>
> > 
> > There are a few things that make the debugging
> > in mac80211 painful:
> >  * pr_debug makes it require *both* Kconfig and
> >    dynamic configuration -- move to pr_info
> 
> pr_info can clutter the log.

Yes, please. We want this information printed unless it's disabled :-)

> >  * the macros still need trailing newlines
> 
> That's not a bad thing.

People are clearly forgetting them all the time. So I don't see any
reason to not add them in the macros if we're going to have macros
anyway.

> > @@ -317,7 +318,7 @@ ieee80211_agg_splice_packets(struct ieee80211_sub_if_data *sdata,
> >  	ieee80211_stop_queue_agg(sdata, tid);
> >  
> >  	if (WARN(!tid_tx, "TID %d gone but expected when splicing aggregates"
> > -			  " from the pending queue\n", tid))
> > +			  " from the pending queue", tid))
> 
> 
> defective.
> 
> Don't remove newlines in single modules.

Hm, I was under the impression WARN() didn't require a newline. Looks
like either that changed, or I was wrong -- will change this back.

> Using a single style _with_ a newline limits defects and
> limits the likely misuse in other styles.

I'd rather have double newlines once a while than missing ones. I've
seen a lot of bugs with missing newlines, which is rather annoying.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html