netdev - Re: [PATCH 4/6] mac80211: clean up debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1340376549.31821.19.camel@joe2Laptop>
Date:	Fri, 22 Jun 2012 07:49:09 -0700
From:	Joe Perches <joe@...ches.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	linux-wireless@...r.kernel.org, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 4/6] mac80211: clean up debugging

On Fri, 2012-06-22 at 16:43 +0200, Johannes Berg wrote:
> > Using a single style _with_ a newline limits defects and
> > limits the likely misuse in other styles.
> 
> I'd rather have double newlines once a while than missing ones. I've
> seen a lot of bugs with missing newlines, which is rather annoying.

Yeah, I have too.

It's because people add macros that add terminating
newlines and there's no style consistency.

I think you should _not_ add more macros that promote
this inconsistency.

usb's uses of err/warn/info/dbg are going away.

These should too.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html