netdev - Re: [PATCH 1/1] atl1c: fix issue of transmit queue 0 timed out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120626180311.GC5070@tux>
Date:	Tue, 26 Jun 2012 11:03:11 -0700
From:	"Luis R. Rodriguez" <rodrigue@....qualcomm.com>
To:	"Ren, Cloud" <cjren@....qualcomm.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <qca-linux-team@...lcomm.com>,
	<nic-devel@...lcomm.com>, xiong <xiong@....qualcomm.com>
Subject: Re: [PATCH 1/1] atl1c: fix issue of transmit queue 0 timed out

On Tue, Jun 26, 2012 at 12:33:06PM -0300, Ren, Cloud wrote:
> From: xiong <xiong@....qualcomm.com>
> 
> some people report atl1c could cause system hang with following
> kernel trace info:
> ---------------------------------------
> WARNING: at.../net/sched/sch_generic.c:258
> dev_watchdog+0x1db/0x1d0()
> ...
> NETDEV WATCHDOG: eth0 (atl1c): transmit queue 0 timed out
> ...
> ---------------------------------------
> This is caused by netif_stop_queue calling when cable Link is down
> but netif_wake_queue isn't called when cable Link is resume.
> 
> Signed-off-by: xiong <xiong@....qualcomm.com>
> Signed-off-by: Cloud Ren <cjren@....qualcomm.com>

If this fixes  a system hang then this could be a stable
fix -- that is, this should be propagated to older stable
kernels, no?

If so then please add to the commit log a line like this:

Cc: stable@...r.kernel.org [3.4]

Note: this is for the commit log! Right above the line below
that has "---"

  Luis
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html