netdev - Re: [net] ixgbe: Do not pad FCoE frames as this can cause issues with FCoE DDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120626.164535.1370104947946690268.davem@davemloft.net>
Date:	Tue, 26 Jun 2012 16:45:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	alexander.h.duyck@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, sassmann@...hat.com, stable@...r.kernel.org
Subject: Re: [net] ixgbe: Do not pad FCoE frames as this can cause issues
 with FCoE DDP

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue, 26 Jun 2012 00:54:46 -0700

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> FCoE target mode was experiencing issues due to the fact that we were
> sending up data frames that were padded to 60 bytes after the DDP logic had
> already stripped the frame down to 52 or 56 depending on the use of VLANs.
> This was resulting in the FCoE DDP logic having issues since it thought the
> frame still had data in it due to the padding.
> 
> To resolve this, adding code so that we do not pad FCoE frames prior to
> handling them to the stack.
> 
> CC: <stable@...r.kernel.org>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com>
> Tested-by: Ross Brattain <ross.b.brattain@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html