netdev - Re: [PATCH] net: l2tp_eth: use LLTX to avoid LOCKDEP splats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120626.164306.246094482304140679.davem@davemloft.net>
Date:	Tue, 26 Jun 2012 16:43:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	denys@...p.net.lb, netdev@...r.kernel.org, honkiko@...il.com,
	jchapman@...alix.com, romieu@...zoreil.com
Subject: Re: [PATCH] net: l2tp_eth: use LLTX to avoid LOCKDEP splats

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 25 Jun 2012 17:35:45 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Denys Fedoryshchenko reported a LOCKDEP issue with l2tp code.
 ...
> It appears that like most virtual devices, l2tp should be converted to
> LLTX mode.
> 
> This patch takes care of statistics using atomic_long in both RX and TX
> paths, and fix a bug in l2tp_eth_dev_recv(), which was caching skb->data
> before a pskb_may_pull() call.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Denys Fedoryshchenko <denys@...p.net.lb>
> Cc: James Chapman <jchapman@...alix.com>
> Cc: Hong zhi guo <honkiko@...il.com>
> Cc: Francois Romieu <romieu@...zoreil.com>
> ---
> Should be applied after "net: l2tp_eth: fix l2tp_eth_dev_xmit race"

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html