netdev - RE: [PATCH 4/4] pch_gbe: vlan skb len fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40680C535D6FE6498883F1640FACD44D011051C7@ka-exchange-1.kontronamerica.local>
Date:	Tue, 10 Jul 2012 08:25:39 -0700
From:	"Andy Cress" <andy.cress@...kontron.com>
To:	"Ben Hutchings" <bhutchings@...arflare.com>
Cc:	<netdev@...r.kernel.org>
Subject: RE: [PATCH 4/4] pch_gbe: vlan skb len fix

That's a good idea.  Removing the check is simpler, simpler is better.

Yes, apparently I do need to resubmit with a different email client.

Andy

-----Original Message-----
From: Ben Hutchings [mailto:bhutchings@...arflare.com] 
Sent: Monday, July 09, 2012 4:33 PM
To: Andy Cress
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 4/4] pch_gbe: vlan skb len fix

On Mon, 2012-07-09 at 06:30 -0700, Andy Cress wrote:
> Author: Veaceslav Falico <vfalico@...hat.com>
> Date:   Tue Apr 10 08:14:17 2012 +0200
> 
>     pch_gbe: correctly verify skb->len in vlan case
>              to avoid bogus transfer length errors.

This check shouldn't be necessary at all.  Maybe you should remove it
instead of correcting the check?

Also, these patches are word-wrapped, and would not be applicable in
this form.  See Documentation/email-clients.txt.

Ben.