netdev - RE: [PATCH 1/4] pch_gbe: fix the checksum fill to the error location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40680C535D6FE6498883F1640FACD44D011051CC@ka-exchange-1.kontronamerica.local>
Date:	Tue, 10 Jul 2012 08:28:15 -0700
From:	"Andy Cress" <andy.cress@...kontron.com>
To:	"Ben Hutchings" <bhutchings@...arflare.com>
Cc:	<netdev@...r.kernel.org>
Subject: RE: [PATCH 1/4] pch_gbe: fix the checksum fill to the error location

Yes, this needs rework to use the standard routine.
Thanks for the input.

Andy

-----Original Message-----
From: Ben Hutchings [mailto:bhutchings@...arflare.com] 
Sent: Monday, July 09, 2012 4:16 PM
To: Andy Cress
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] pch_gbe: fix the checksum fill to the error location

On Mon, 2012-07-09 at 06:30 -0700, Andy Cress wrote:
> From: Zhong Hongbo <hongbo.zhong@...driver.com>
> Date: Mon, 9 Apr 2012 10:51:28 +0800
> 
[...]
>
> We can fix this issue by manually calculate the offset of the TCP
> checksum
>  and update it accordingly.
[...]

You should be using skb_checksum_start_offset() instead.

Ben.