netdev - Re: [PATCH net-next] ipv6: optimize ipv6 addresses compares

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120710.210221.559183284956265274.davem@davemloft.net>
Date:	Tue, 10 Jul 2012 21:02:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, joe@...ches.com
Subject: Re: [PATCH net-next] ipv6: optimize ipv6 addresses compares

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 11 Jul 2012 05:49:18 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> On 64 bit arches having efficient unaligned accesses (eg x86_64) we can
> use long words to reduce number of instructions for free.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Joe Perches <joe@...ches.com>

Maybe we can even be sure that they are 64-bit aligned too?

If there's an embedded u64 in the in6_addr union, they really should
be.

It can't even be an issue in the protocol headers, because in the
socket demux we read the two 32-bit ipv4 addresses in the packet
header as one 64-bit chunk already.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html