lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1341979398.3265.6648.camel@edumazet-glaptop> Date: Wed, 11 Jul 2012 06:03:18 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Li Yu <raise.sail@...il.com> Cc: Linux Netdev List <netdev@...r.kernel.org> Subject: Re: [RFC][PATCH 1/4] skbtrace: core feature On Wed, 2012-07-11 at 10:17 +0800, Li Yu wrote: > From: Li Yu <bingtian.ly@...bao.com> > > This implements core feature of skbtrace, which contains glue code of > tracepoints subsystem and relay file system, and provide skbtrace API > for particular networking traces. > > Thanks Hi Li This seems a huge amount of code, on an already complex stack. I am not convinced its needed. It looks like a debugging aid you had to write in order to understand better linux network stack. Lets see if you manage to maintain this for a while before considering upstreaming it. You said that some 'buggy' drivers set rxhash to zero, but its a valid operation. You said 'it seems that RPS hashing can not work well for some corner cases', but its a known fact. Thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists