netdev - Re: [PATCH net-next] ipv6: optimize ipv6 addresses compares

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1341982416.3265.6764.camel@edumazet-glaptop>
Date:	Wed, 11 Jul 2012 06:53:36 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, joe@...ches.com
Subject: Re: [PATCH net-next] ipv6: optimize ipv6 addresses compares

On Wed, 2012-07-11 at 06:44 +0200, Eric Dumazet wrote:

> I dont see where in demux code we have a 64bit access ?

I guess you meant the code in include/net/inet_hashtables.h ?

INET_ADDR_COOKIE() loads the two 32bits into one 64bit register/var
So there is no 64bit alignment in packet header itself.

Then, INET_MATCH does a *(u64 *)&(inet_sk(__sk)->inet_daddr)))

This happens to work because skc_daddr & skc_rcv_saddr are at the
beginning of struct sock_common, and its 8bytes aligned on 64bit arches.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html