netdev - Re: Crash in CIPSO_V4_TAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120714.130817.394766887121758073.davem@davemloft.net>
Date:	Sat, 14 Jul 2012 13:08:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mlin@...pku.edu.cn
Cc:	alan@...rguk.ukuu.org.uk, paul.moore@...com, netdev@...r.kernel.org
Subject: Re: Crash in CIPSO_V4_TAG_LOCAL handling

From: Lin Ming <mlin@...pku.edu.cn>
Date: Sun, 15 Jul 2012 01:22:30 +0800

> It's caused by below code added in commit 15c45f7b.
> 
>                 case CIPSO_V4_TAG_LOCAL:
>                         /* This is a non-standard tag that we only allow for
>                          * local connections, so if the incoming interface is
>                          * not the loopback device drop the packet. */
>                         if (!(skb->dev->flags & IFF_LOOPBACK)) {
>                                 err_offset = opt_iter;
>                                 goto validate_return_locked;
>                         }

Paul please fix this, as shown 'skb' can easily be NULL in this
code path.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html