netdev - Re: Crash in CIPSO_V4_TAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhQKhoRt8yD4WAgD5tyqjY4bbp4Z4hr5cWfs-d6GJt0pjQ@mail.gmail.com>
Date:	Tue, 17 Jul 2012 12:25:28 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	David Miller <davem@...emloft.net>
Cc:	mlin@...pku.edu.cn, alan@...rguk.ukuu.org.uk,
	netdev@...r.kernel.org
Subject: Re: Crash in CIPSO_V4_TAG_LOCAL handling

On Sat, Jul 14, 2012 at 4:08 PM, David Miller <davem@...emloft.net> wrote:
> From: Lin Ming <mlin@...pku.edu.cn>
> Date: Sun, 15 Jul 2012 01:22:30 +0800
>
>> It's caused by below code added in commit 15c45f7b.
>>
>>                 case CIPSO_V4_TAG_LOCAL:
>>                         /* This is a non-standard tag that we only allow for
>>                          * local connections, so if the incoming interface is
>>                          * not the loopback device drop the packet. */
>>                         if (!(skb->dev->flags & IFF_LOOPBACK)) {
>>                                 err_offset = opt_iter;
>>                                 goto validate_return_locked;
>>                         }
>
> Paul please fix this, as shown 'skb' can easily be NULL in this
> code path.

Just saw this ... I'll start looking into this today.

-- 
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html