netdev - Re: [PATCH net-next 2/7] sfc: Add channel specific receive_skb handler and post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120718.114338.1739885494531439089.davem@davemloft.net>
Date:	Wed, 18 Jul 2012 11:43:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
	ajackson@...arflare.com, richardcochran@...il.com
Subject: Re: [PATCH net-next 2/7] sfc: Add channel specific receive_skb
 handler and post_remove callback

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 18 Jul 2012 19:42:42 +0100

> On Wed, 2012-07-18 at 11:32 -0700, David Miller wrote:
>> From: Ben Hutchings <bhutchings@...arflare.com>
>> Date: Wed, 18 Jul 2012 19:20:00 +0100
>> 
>> > +	void (*receive_skb)(struct efx_channel *, struct sk_buff *);
>> 
>> This looks to me like a conduit for proprietary features implemented
>> in a binary-only blob.
>> 
>> I understand how you're using here for PTP, but you're really openning
>> the door for things I really wouldn't be very happy about.
> 
> Through all the functions that, er, aren't exported?
> 
> Even in the out-of-tree version of sfc there is no receive path hook any
> more; I converted the client driver that wanted it (which is under GNU
> GPL, thank you very much) to use netfilter.

Fair enough, in light of that this doesn't bother me so much :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html