netdev - Re: [PATCH 2/3] pch_gbe: add extra clean tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120726.143136.495599687146212368.davem@davemloft.net>
Date:	Thu, 26 Jul 2012 14:31:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andycress@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] pch_gbe: add extra clean tx

From: Andy Cress <andycress@...il.com>
Date: Thu, 26 Jul 2012 12:00:11 -0400

> This adds extra cleaning to the pch_gbe_clean_tx routine to avoid 
> transmit timeouts on some BCM PHYs that have different timing.
> Also update the DRV_VERSION to 1.01, and show it.
> 
> Signed-off-by: Andy Cress <andy.cress@...kontron.com>

Applied.

 ....
> +		if (unused < 8) {  /* tx queue nearly full */
> +			pr_debug("clean_tx: transmit queue warning (%x,%x) unused=%d\n",
> +				tx_ring->next_to_clean,tx_ring->next_to_use,unused);
> +		}
> +	   
   ^^^^^^^^^^

Trailing whitespace.

> +		for (j = 0; j < PCH_GBE_TX_WEIGHT; j++) 
                                                       ^^^

Likewise.

Clean this crap up before submitting patches formally, so I don't have
to.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html