netdev - Re: [PATCH 3/3] pch_gbe: vlan skb len fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120726.143142.935341464119402864.davem@davemloft.net>
Date:	Thu, 26 Jul 2012 14:31:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andycress@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] pch_gbe: vlan skb len fix

From: Andy Cress <andycress@...il.com>
Date: Thu, 26 Jul 2012 12:01:17 -0400

> 
> pch_gbe_xmit_frame skb->len verification was incorrect in vlan case 
> causing bogus transfer length errors.  One correction could be:
>     offset = skb->protocol == htons(ETH_P_8021Q) ? 0 : 4;
>     if (unlikely(skb->len > (adapter->hw.mac.max_frame_size - offset))) 
> However, this verification is not necessary, so remove it.
> 
> Signed-off-by: Andy Cress <andy.cress@...kontron.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html