netdev - Re: [PATCH 2/2] ipv4: Properly purge netdev references on uncached routes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120731.160408.994710172149748635.davem@davemloft.net>
Date:	Tue, 31 Jul 2012 16:04:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ipv4: Properly purge netdev references on uncached
 routes.

From: Stephen Hemminger <shemminger@...tta.com>
Date: Tue, 31 Jul 2012 15:44:55 -0700

> On Tue, 31 Jul 2012 15:20:33 -0700 (PDT)
> David Miller <davem@...emloft.net> wrote:
> 
>> 
>> When a device is unregistered, we have to purge all of the
>> references to it that may exist in the entire system.
>> 
>> If a route is uncached, we currently have no way of accomplishing
>> this.
>> 
>> So create a global list that is scanned when a network device goes
>> down.  This mirrors the logic in net/core/dst.c's dst_ifdown().
>> 
>> Signed-off-by: David S. Miller <davem@...emloft.net>
> 
> What about systems will full 1M route table?
> I wonder if doing rbtree here would make the search faster?

It only happens for routes like 255.255.255.255 and for those who
use tclassid on input.

Everything else is cached in the existing FIB trie entries.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html