netdev - Re: [PATCH 2/2] ipv4: Properly purge netdev references on uncached routes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1345822847.19483.8.camel@edumazet-glaptop>
Date:	Fri, 24 Aug 2012 17:40:47 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ipv4: Properly purge netdev references on uncached
 routes.

From: Eric Dumazet <edumazet@...gle.com>

On Tue, 2012-07-31 at 16:04 -0700, David Miller wrote:
> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Tue, 31 Jul 2012 15:44:55 -0700
> 
> > On Tue, 31 Jul 2012 15:20:33 -0700 (PDT)
> > David Miller <davem@...emloft.net> wrote:
> > 
> >> 
> >> When a device is unregistered, we have to purge all of the
> >> references to it that may exist in the entire system.
> >> 
> >> If a route is uncached, we currently have no way of accomplishing
> >> this.
> >> 
> >> So create a global list that is scanned when a network device goes
> >> down.  This mirrors the logic in net/core/dst.c's dst_ifdown().
> >> 
> >> Signed-off-by: David S. Miller <davem@...emloft.net>
> > 
> > What about systems will full 1M route table?
> > I wonder if doing rbtree here would make the search faster?
> 
> It only happens for routes like 255.255.255.255 and for those who
> use tclassid on input.
> 
> Everything else is cached in the existing FIB trie entries.

We might have an SMP performance regression on multicast traffic,
because DST_NOCACHE is set on such routes.

What about the following ?

Thanks

[PATCH] ipv4: take rt_uncached_lock only if needed

Multicast traffic allocates dst with DST_NOCACHE, but dst is
not inserted into rt_uncached_list.

This slowdown multicast workloads on SMP because rt_uncached_lock is
contended.

Change the test before taking the lock to actually check the dst
was inserted into rt_uncached_list.

Signed-off-by: Eric Dumazet <edumazet@...gle.com>
---
 net/ipv4/route.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 8c8c748..24fd4c5 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1263,7 +1263,7 @@ static void ipv4_dst_destroy(struct dst_entry *dst)
 {
 	struct rtable *rt = (struct rtable *) dst;
 
-	if (dst->flags & DST_NOCACHE) {
+	if (!list_empty(&rt->rt_uncached)) {
 		spin_lock_bh(&rt_uncached_lock);
 		list_del(&rt->rt_uncached);
 		spin_unlock_bh(&rt_uncached_lock);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html