[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120807170702.GH2378@linux.vnet.ibm.com>
Date: Tue, 7 Aug 2012 10:07:02 -0700
From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To: Eric Dumazet <eric.dumazet@...il.com>
Cc: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: fib: fix incorrect call_rcu_bh()
On Tue, Aug 07, 2012 at 06:48:14PM +0200, Eric Dumazet wrote:
> On Tue, 2012-08-07 at 09:34 -0700, Paul E. McKenney wrote:
> > On Tue, Aug 07, 2012 at 12:47:11PM +0200, Eric Dumazet wrote:
> > > From: Eric Dumazet <edumazet@...gle.com>
> > >
> > > After IP route cache removal, I believe rcu_bh() has very little use and
> > > we should remove this RCU variant, since it adds some cycles in fast
> > > path.
> >
> > Do you mean remove all uses of RCU-bh globally and also removing the
> > implementation itself? That would actually be a good thing, from my
> > perspective.
> >
>
> Yes I meant that there are now too few rcu_bh users, and that they
> probably could switch to regular rcu.
>
> We could then remove the implementation.
>
> rcu_bh was needed because we could sit forever in softirq mode in one
> cpu, and we needed to allocate/free dsts with RCU protection.
Very cool!!! Anything I can do to help, aside of course from the final
removal of RCU-bh support?
Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists